D15916: Rewrite the painting part of agandaitem

Daniel Vrátil noreply at phabricator.kde.org
Wed Oct 3 12:57:06 BST 2018


dvratil added inline comments.

INLINE COMMENTS

> agendaitem.cpp:1143
> +    const int RECT_MARGIN = 2; // the distance between two item is then RECT_MARGIN * 2
> +    const int RADIUS = 4; // absolute radius
> +    

Could you try how it looks with `RADIUS = 2`? That might make it look close to what Breeze widgets look like (the rounderd corners are barely visible there).

> agendaitem.cpp:1165
> +    } else if (roundBottom) {
> +        // not used and tested
> +        path.moveTo(pointRightTop);

I believe you should get here if an event in agenda spans multiple days: then the top is rounded only on the first day and the bottom is rounded only on the end day.

REPOSITORY
  R76 PIM: Event Views

REVISION DETAIL
  https://phabricator.kde.org/D15916

To: ognarb, #kde_pim, #kde_pim_junior_jobs, mlaurent, dvratil
Cc: lbeltrame, kde-pim, maciejn, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181003/e21ec8b0/attachment.html>


More information about the kde-pim mailing list