D16557: Move non-optional ModelSpy dependency to ctor
Daniel Vrátil
noreply at phabricator.kde.org
Thu Nov 1 12:36:26 GMT 2018
dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.
I would say that the `ModelSpy` should even be created on the stack because the way it is now it leaks from one test run to another (`this` is only destroyed after all tests methods are executed).
Would you mind changing that, since you are touching the tests?
REPOSITORY
R165 Akonadi
BRANCH
model-spy-nonoptional-dependency
REVISION DETAIL
https://phabricator.kde.org/D16557
To: dkurz, #kde_pim, dvratil
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181101/4d0a7202/attachment.html>
More information about the kde-pim
mailing list