D16590: Express intent to compare model columns more directly
Denis Kurz
noreply at phabricator.kde.org
Thu Nov 1 15:01:24 GMT 2018
dkurz created this revision.
dkurz added a reviewer: KDE PIM.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
dkurz requested review of this revision.
REVISION SUMMARY
Those two tests had mixed levels of abstraction, plus they
both implemented the same test, but differently. A method is extracted
so the intend can be expressed in one simple line in the tests. We
also duplicate less code this way.
REPOSITORY
R165 Akonadi
BRANCH
express-column-compare-intent
REVISION DETAIL
https://phabricator.kde.org/D16590
AFFECTED FILES
autotests/libs/modelspy.cpp
To: dkurz, #kde_pim
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181101/e7cb2db6/attachment.html>
More information about the kde-pim
mailing list