D16559: Fix unused-object warnings

Denis Kurz noreply at phabricator.kde.org
Thu Nov 1 12:53:31 GMT 2018


dkurz marked an inline comment as done.
dkurz added a comment.


  `arcanist` complains that this Diff has not been accepted. In general, should I wait for positive feedback from the same reviewer after all requested changes from this reviewer have been fixed and accepted by another reviewer?

INLINE COMMENTS

> dvratil wrote in agentbase.cpp:908
> This is OK the way it is: this is a special code for Windows, so it's `ifdef`ed correctly.

It is now, after I moved `Q_UNUSED(argv)` to the `else` branch. Laurent was right about this.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D16559

To: dkurz, #kde_pim, mlaurent, dvratil
Cc: dvratil, mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181101/04abd7ab/attachment.html>


More information about the kde-pim mailing list