D8843: Use URLs in multiget requests as returned by the Server

[David Faure]

dfaure added a comment.


  Here's some debug output to understand what's going on:
  
    KDAV::DavItemsListJob::davJobFinished: D8843 difference: href="/calendars/dfaure at kdab.com/02af0002-0181-4d55-88a7-db543be67d83/dd261076-60eb-40c2-b6fe-a245f69eac66.ics"
    
    old code QUrl("https://caldav.kdab.com/calendars/dfaure@kdab.com/02af0002-0181-4d55-88a7-db543be67d83/dd261076-60eb-40c2-b6fe-a245f69eac66.ics")
        DavUrl: [ CalDav QUrl("https://dfaure%40kdab.com@caldav.kdab.com/calendars/dfaure@kdab.com/02af0002-0181-4d55-88a7-db543be67d83/dc3eb14d-fb62-4ddc-b7c5-9d8b3eb5fc02.ics") ]
    
    new code QUrl("/calendars/dfaure at kdab.com/02af0002-0181-4d55-88a7-db543be67d83/dd261076-60eb-40c2-b6fe-a245f69eac66.ics")
        DavUrl: [ CalDav QUrl("//dfaure%40kdab.com@/calendars/dfaure at kdab.com/02af0002-0181-4d55-88a7-db543be67d83/901926d0-3732-4e0b-87d1-800f6db33c29.ics") ]    
  
  And when enabling the new code (i.e. this patch), here's what I get later on:
  
    KDAV::DavItemsFetchJob::start <calendar-multiget xmlns="urn:ietf:params:xml:ns:caldav">
     <prop xmlns="DAV:">
          <getetag xmlns="DAV:"/>
      <calendar-data xmlns="urn:ietf:params:xml:ns:caldav"/>
     </prop>
     <href xmlns="DAV:">file:///calendars/dfaure@kdab.com/02af0002-0181-4d55-88a7-db543be67d83/dd261076-60eb-40c2-b6fe-a245f69eac66.ics</href>
     [...]
    
    DavGroupwareResource::onMultigetFinished: Empty item returned.  "/calendars/dfaure at kdab.com/02af0002-0181-4d55-88a7-db543be67d83/66182bae-53b2-11e8-8fd1-dd97c1cc0e20.ics"
  
  The QUrl in the "new code" case looks very broken to me, with a username and no host and no scheme, and sending a file: URL looks very wrong too.

REPOSITORY
  R490 KDAV Library

REVISION DETAIL
  https://phabricator.kde.org/D8843

To: rhaferkamp, #kde_pim, knauss
Cc: equaeghe, bbreinbauer, mlaurent, dfaure, vkrause, winterz, knauss, #kde_pim, dvasin, rodsevich, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181116/c05fa00f/attachment.html>