D16799: BUG: 400859 fixing inbox detection

Pino Toscano noreply at phabricator.kde.org
Sat Nov 10 12:31:53 GMT 2018


pino added inline comments.

INLINE COMMENTS

> mailkernel.cpp:373
>      if (collectionRemoteIdLower == QLatin1String("inbox")
> -        || collectionRemoteIdLower == QLatin1String("/inbox")
> -        || collectionRemoteIdLower == QLatin1String(".inbox")) {
> +        || collectionRemoteIdLower.indexOf(QLatin1String("inbox")) == 1) {
>          return true;

This looks too broad to me. For example, if I have a folder called "linboxes", then it will be wrongly recognized as inbox now.

I'm not a PIM developer, but IMHO the solution is to add yet another particular case here.

REPOSITORY
  R92 PIM: Common Mail Support

REVISION DETAIL
  https://phabricator.kde.org/D16799

To: ypashkovsky, #kde_pim_kmail
Cc: pino, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181110/f1dd39e5/attachment.html>


More information about the kde-pim mailing list