D16559: Fix unused-object warnings
Daniel Vrátil
noreply at phabricator.kde.org
Thu Nov 1 13:24:25 GMT 2018
dvratil added a comment.
In thin particular case it's OK to merge now - you fixed what Laurent asked for and there's hardly anything else in this patch to complain about :-)
INLINE COMMENTS
> dkurz wrote in agentbase.cpp:908
> It is now, after I moved `Q_UNUSED(argv)` to the `else` branch. Laurent was right about this.
Ah, sorry: I haven't noticed the comment was for a previous revision and though Laurent wanted you to swap the `ifdef` logic.
REPOSITORY
R165 Akonadi
REVISION DETAIL
https://phabricator.kde.org/D16559
To: dkurz, #kde_pim, mlaurent, dvratil
Cc: dvratil, mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20181101/1282e3af/attachment.html>
More information about the kde-pim
mailing list