D12738: Use TableView for debug page.

Daniel Vrátil noreply at phabricator.kde.org
Mon May 7 14:57:44 BST 2018


dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Since the view is backed by QStandardItemModel I think it would be better to use `appendRow()`:
  
    auto out = new QStandardItem(QStringLiteral("->"));
    out->setForeground(Qt::green);
    mModel->appendRow({ new QStandardItem(identifier), out, new QStandardItem(msg.trimmed());
  
  and analogously for the other direction

INLINE COMMENTS

> connectionpage.cpp:38-40
> +    mModel->setHeaderData(0, Qt::Horizontal, QStringLiteral("Sender"));
> +    mModel->setHeaderData(1, Qt::Horizontal, QStringLiteral("Direction"));
> +    mModel->setHeaderData(2, Qt::Horizontal, QStringLiteral("Message"));

mModel->setVerticalHeaderLabels({ QStringLiteral("Sender"), QStringLiteral("Direction"), QStringLiteral("Message") });

REPOSITORY
  R199 Akonadi Console

REVISION DETAIL
  https://phabricator.kde.org/D12738

To: knauss, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180507/9ffde239/attachment.html>


More information about the kde-pim mailing list