D12736: Add toJson method for the protocol.

Daniel Vrátil noreply at phabricator.kde.org
Sun May 13 11:15:14 BST 2018


dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, thanks a lot! Just resolve the Relation serialization and I think we are good to go.

INLINE COMMENTS

> cppgenerator.cpp:649
> +                if (TypeHelper::containerType(prop->type()) == QStringLiteral("Akonadi::Protocol::ChangeNotification::Relation")) {
> +                    //No idea what to do here...
> +                } else {

Just add toJSON() to the Relation class.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D12736

To: knauss, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180513/addf4996/attachment.html>


More information about the kde-pim mailing list