D13004: Use QProxyFilterModel to filter debug messages.

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Nice!! Two minor nitpicks, just fix them before pushing. Thanks a lot for working on this, Sandro!

INLINE COMMENTS

> debugmodel.cpp:39
> +
> +QString DebugModel::displaySender(QString identifer) const
> +{

const &

> debugmodel.h:33
> +    enum Direction {
> +        Input,
> +        Output

This is a bit confusing because what's client's output is server's input :) I'd prefer having values that  are more clear, like `ServerToClient` and `ClientToServer`, or changing the enum completely from //direction// to //sender//.

REPOSITORY
  R199 Akonadi Console

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13004

To: knauss, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180521/1b195c7b/attachment.html>