D13104: Protocol: QJsonObject for tracer.

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> dvratil wrote in protocol.cpp:207
> Hmm, right. Then at least fix the missing chai-up from `ChangeNotification` to `Command` :)

there is no missing chain-up for ChangeNotification - as we are triggering this by the base class (command) otherwise we would end in an endless loop for ChangeNotification.

> dvratil wrote in protocol_p.h:158
> Because it's a proper overload. With the current approach the `toJson()` methods in subclasses overshadow/hide the parent class implementations without them being virtual (which we still call however) so that's not too nice.

how this should work? when using the operator I still would need to cast to baseclass/clientclass on my own - so where would be the advantage?

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D13104

To: knauss, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180528/9eb63c59/attachment.html>