D12736: Add toJson method for the protocol.

Sandro Knauß noreply at phabricator.kde.org
Mon May 21 09:53:49 BST 2018


knauss added inline comments.

INLINE COMMENTS

> dvratil wrote in scope.cpp:329
>   const auto chain = hridChain();
>   for (const auto &hrid : chain) {
>     ..
>   }
> 
> to prevent detaching the returned container.

my compiler is unhappy with the `const auto chain = hridChain();` line in the switch:

  /home/neon/kdepim/src/kde/pim/akonadi/src/private/scope.cpp: In member function 'QTextStream& Akonadi::Scope::toJson(QTextStream&) const':                                                                                                    
  /home/neon/kdepim/src/kde/pim/akonadi/src/private/scope.cpp:339:5: error: jump to case label [-fpermissive]
  /home/neon/kdepim/src/kde/pim/akonadi/src/private/scope.cpp:329:21: note:   crosses initialization of 'const QVector<Akonadi::Scope::HRID>& chain'
  /home/neon/kdepim/src/kde/pim/akonadi/src/private/scope.cpp:317:12: warning: enumeration value 'Invalid' not handled in switch [-Wswitch]

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D12736

To: knauss, dvratil
Cc: #kde_pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180521/a7d18ca7/attachment.html>


More information about the kde-pim mailing list