D13041: Enable Json output for dbustracer.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> tracer.cpp:101
> +        connectionInput(identifier, msg);
> +    }
> +

You should `return` here, or put the code below to an `else` branch, otherwise we are going to send each message twice.

> tracer.cpp:128
> +        connectionOutput(identifier, msg);
> +    }
> +

Same comment as in `connectionInput`.

> tracer.h:39
> +
>  namespace Akonadi
>  {

Not needed?

> tracerinterface.h:44
> +    enum ConnectionFormat {
> +        DebugString,
> +        Json

What is the purpose of this? The `DebugString` value is not referenced anywhere and the question is - do we want to? If we have JSON format, there's no need for plain string messages, is there? We don't need to concern ourselves with backwards compatibility anymore, since Akonadi and akonadiconsole are on the same release cycle now.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D13041

To: knauss, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180523/0d15edab/attachment.html>