D12736: Add toJson method for the protocol.

Daniel Vrátil noreply at phabricator.kde.org
Mon May 21 08:30:31 BST 2018


dvratil added inline comments.

INLINE COMMENTS

> knauss wrote in cppgenerator.cpp:631
> this needs also be done at all other usages of serializeProperties , as they only read data this is not an issue, right?

This only needs to be done when using a non-const Qt container in a range-based for loop, because it calls non-const `begin()` and `end()`, causing the container to detach if it is (or could be) shared

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D12736

To: knauss, dvratil
Cc: #kde_pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180521/e72fbb69/attachment.html>


More information about the kde-pim mailing list