Review Request 130249: kldap: add support for TLS CA certificate handling

Laurent Montel montel at kde.org
Tue Mar 20 17:17:16 GMT 2018


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130249/#review103867
-----------------------------------------------------------



You can't click on "ship it" as you are the creator of patch

- Laurent Montel


On mars 20, 2018, 4:51 après-midi, Tobias Junghans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130249/
> -----------------------------------------------------------
> 
> (Updated mars 20, 2018, 4:51 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> This implements basic support for setting the TLS certificate request option (LDAP_OPT_X_TLS_REQUIRE_CERT) as well as a dedicated certificate
> file for checking server certificate (LDAP_OPT_X_TLS_CACERTFILE).
> 
> 
> Testing
> -------
> 
> TLS connection to LDAP server with self-signed certificate
> 
> * scenario a) none of the new options set -> connection fails due to missing certificate to check against
> * scenario b) use LdapServer::TLSReqCertNever which makes the connection succeed
> * scenario c) use LdapServer::TLSReqCertHard and set tlsCACertFile which makes the connection succeed
> 
> 
> File Attachments
> ----------------
> 
> 0001-Add-support-for-TLS-CA-certificate-handling.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2018/03/20/69f4abb3-fa32-47da-90c6-a133314aaa6e__0001-Add-support-for-TLS-CA-certificate-handling.patch
> 
> 
> Thanks,
> 
> Tobias Junghans
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180320/b6b05baa/attachment.html>


More information about the kde-pim mailing list