D11385: Article viewer: Reset scroll position when loading a new article

Jonathan Marten noreply at phabricator.kde.org
Fri Mar 16 11:33:59 GMT 2018


marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.
marten requested review of this revision.

REVISION SUMMARY
  This is the fix for the article viewer not scrolling back to the top when loading a new article, as suggested in https://bugs.kde.org/show_bug.cgi?id=382587 comment 2.  In theory this should not be necessary as the article is scrolled to the top via JavaScript, but this does not appear to work in the reported cases.
  
  As an added bonus, this change appears to improve the performance of the application when moving between articles with "Next unread article" or similar, the change happening instantly instead of there being a perceptible delay.  However, this is just my subjective observation.

TEST PLAN
  Built akregator with this change, observed that the article viewer is reliably scrolled back to the top when showing a new article.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D11385

AFFECTED FILES
  src/articleviewer-ng/webengine/articlehtmlwebenginewriter.cpp

To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180316/8ea6e7bd/attachment.html>


More information about the kde-pim mailing list