D11284: Reader window opened on message in trash still shows "Move to trash" action

Laurent Montel noreply at phabricator.kde.org
Wed Mar 14 06:26:55 GMT 2018


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> util.cpp:183
> +{
> +    action->setText(isInTrashFolder ? i18nc("@action Hard delete, bypassing trash", "&Delete") : i18n("&Move to Trash"));
> +    action->setIcon(isInTrashFolder ? QIcon::fromTheme(QStringLiteral("edit-delete")) : QIcon::fromTheme(QStringLiteral("user-trash")));

Add a if (action) by default it's always true but I prefer to be safe.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D11284

To: marten, #kde_pim, mlaurent
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180314/d1e5a1f9/attachment.html>


More information about the kde-pim mailing list