D9715: Fix duplicated entries in Google Calendar and Tasks resource settings dialog

[Igor Poboiko]

poboiko added a comment.


  The workaround in GoogleSettingsDialog::reloadAccounts() (with disconnecting/connecting) doesn't work because signal gets connected as
  
  - connect(m_accComboBox, QOverload<const QString &>::of(&KComboBox::currentIndexChanged), this, &GoogleSettingsDialog::currentAccountChanged);
  
  and gets disconnected as
  
  - disconnect(m_accComboBox, SIGNAL(currentIndexChanged(QString)), this, SIGNAL(currentAccountChanged(QString)));
  
  Somehow it doesn't match (?), and does not disconnect. If I switch to new signal/slot API in disconnect, the GoogleSettingsDialog::currentAccountChanged signal gets emitted only once. Probably, this is a better solution.

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D9715

To: poboiko, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180107/a3060a3d/attachment.html>