D9885: Retrieve OAuth2 token with HTTP socket

[David Kahles]

davidk updated this revision to Diff 25669.
davidk added a comment.


  Unfortunately i can't reproduce the crash (with QT 5.10.0).
  
  But it may be related to the redirection to localhost, because i don't return a valid http response to the webview.
  Instead, i close the connection after recieving the request. I added a line to cancel the page load, after recieving
  the request on the socket. I hope this fixes the problem.
  
  I wonder why the change breaks kio-gdrive but not the other applications i tried. Maybe it's related to the nested QEventLoop?
  
  Anyways, would you mind trying it again?

REPOSITORY
  R477 KGAPI Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9885?vs=25575&id=25669

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9885

AFFECTED FILES
  src/core/private/newtokensfetchjob.cpp
  src/core/private/newtokensfetchjob_p.h
  src/core/ui/authwidget.cpp
  src/core/ui/authwidget_p.cpp
  src/core/ui/authwidget_p.h

To: davidk, mlaurent, dvratil, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180120/183c49b8/attachment.html>