D9972: SMTP: fix truncated attachment if it contains a line with a single dot
David Faure
noreply at phabricator.kde.org
Thu Jan 18 21:58:10 GMT 2018
dfaure created this revision.
dfaure added a reviewer: dvratil.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: KDE PIM.
dfaure requested review of this revision.
REVISION SUMMARY
In SMTP speak, a line with a single dot means end of message. So if
we're attaching a text file that contains such a line, we need to
"escape" it by making it two dots, as the spec says.
No unescaping code needed, the SMTP server takes care of it.
TEST PLAN
Sending a text file that starts with ".\n" used to send
an empty file, now it works, I get the full file, intact.
REPOSITORY
R733 KSmtp
BRANCH
Applications/17.12
REVISION DETAIL
https://phabricator.kde.org/D9972
AFFECTED FILES
src/sendjob.cpp
To: dfaure, dvratil
Cc: mlaurent, olivierjg, #kde_pim, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180118/31bd7210/attachment.html>
More information about the kde-pim
mailing list