D9885: Retrieve OAuth2 token with HTTP socket

[David Kahles]

davidk added a comment.


  I'm fine with putting a QStringLiteral version into 17.12.

INLINE COMMENTS

> dvratil wrote in authwidget_p.cpp:261
> Please add `qCDebug(KGAPIRaw)` that logs the content of the received data for easier debugging in case there's an error.

I don't want to log the recieved data, as I don't want to log the recieved token. Another fast enough application may grab it and access your data. There is a commented log in line 277, one can enable to log it.

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D9885

To: davidk, mlaurent, dvratil, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180118/6f54f18c/attachment.html>