D9885: Retrieve OAuth2 token with HTTP socket

David Kahles noreply at phabricator.kde.org
Wed Jan 17 13:26:58 GMT 2018


davidk added inline comments.

INLINE COMMENTS

> mlaurent wrote in authwidget_p.cpp:259
> it will crash if line is empty no or == 1 ? Perhaps you can test it no ?

I don't think it will crash. If line.size() is unequal 3, the remaining checks will be skipped (lazy evaluation). Those will only be checked, if line.size() == 3.
Or did I missunderstand your comment?

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D9885

To: davidk, mlaurent, dvratil, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180117/a8acb842/attachment.html>


More information about the kde-pim mailing list