D10221: Set error if oauth dialog is aborted

Daniel Vrátil noreply at phabricator.kde.org
Thu Feb 1 08:29:01 GMT 2018


dvratil added a comment.


  You are on a roll!

INLINE COMMENTS

> authjob.cpp:248
> +                    d->_k_destructDelayed();
> +                    d->_k_fullAuthenticationFailed(AuthCancelled, tr("You canceled the authentication"));
> +                });

Just "Authentication canceled" would be better I think. The current string sounds like we are trying to make the user feel bad for canceling it. What do you think?

REPOSITORY
  R477 KGAPI Library

REVISION DETAIL
  https://phabricator.kde.org/D10221

To: davidk, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180201/2446c582/attachment.html>


More information about the kde-pim mailing list