D15065: Implement Unified Mailboxes agent

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:18
> +)
> +ecm_qt_declare_logging_category(unifiedmailbox_agent_SRCS HEADER unifiedmailboxagent_debug.h IDENTIFIER agent_log CATEGORY_NAME org.kde.pim.unifiedmailboxagent)
> +kconfig_add_kcfg_files(unifiedmailbox_agent_SRCS

please add this info in kmail.categories too

> unifiedmailbox.h:32
> +
> +class UnifiedMailbox {
> +    friend class UnifiedMailboxManager;

coding style \n before {

> unifiedmailboxeditor.cpp:93
> +{
> +    resize(500, 900);
> +

it's better to make this dialog able to save/load size (as other dialog)

> unifiedmailboxmanager.cpp:288
> +
> +UnifiedMailbox * UnifiedMailboxManager::unifiedMailboxFromCollection(const Akonadi::Collection &col) const
> +{

remove space after *

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D15065

To: dvratil, mlaurent
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180828/7f76a7cc/attachment.html>