D14709: Start to implement rental car support

Volker Krause noreply at phabricator.kde.org
Thu Aug 9 18:17:40 BST 2018


vkrause added inline comments.

INLINE COMMENTS

> place.h:134
> + */
> +class KITINERARY_EXPORT RentalCarPlace : public Place
> +{

Hm, Googles example data uses the `Place` type directly rather than a specialized sub-type: https://developers.google.com/gmail/markup/reference/rental-car . This means on deserialization we would fail with their data right now. I see a few options to address this:
(1) make the properties in `RentalCarReservation` QVariants to accept both types
(2) convert Place to `RentalCarPlace` in `JsonLdImportFilter`
(3) if we don't need any extra properties on `RentalCarPlace` on top of `Place` (now and foreseeable future), use `Place` directly and convert `RentalCarPlace` to `Place` in the import filter.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D14709

To: mlaurent, vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180809/28c28f2f/attachment.html>


More information about the kde-pim mailing list