D14902: Port Archive mail agent to new config API

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> archivemailagent.cpp:124
>  }
> -
> +#if 0
>  void ArchiveMailAgent::configure(WId windowId)

if it's comment better to remove it

> archivemailwidget.h:46
>  public:
> -    explicit ArchiveMailWidget(QWidget *parent = nullptr);
> +    explicit ArchiveMailWidget(KSharedConfigPtr config, QWidget *parentWidget, const QVariantList &args);
>      ~ArchiveMailWidget();

const KSharedConfigPtr& no ?

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D14902

To: dvratil, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180817/1183978b/attachment.html>