D14563: Add CLDR-based country to ISO code mapping

Sune Vuorela noreply at phabricator.kde.org
Thu Aug 2 20:23:09 BST 2018


svuorela added inline comments.

INLINE COMMENTS

> winterz wrote in CMakeLists.txt:1
> I don't have this path on my system.
> I suppose I'll need to find it and perhaps install the necessary package.
> 
> we need CMake code that handles the missing CLDR data files more nicely

On debian, they are located in /usr/share/unicode/cldr/common/main/

> translatedcountrylist.h:29
> +
> +namespace TranslatedCountries {
> +    using TranslationCountryMap = QHash<QString,QString>;

iirc, I also did some basic unit testing of these functions. Maybe we should integrate them as well ?

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D14563

To: vkrause
Cc: svuorela, winterz, kde-pim, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180802/d0bb4372/attachment.html>


More information about the kde-pim mailing list