D14563: Add CLDR-based country to ISO code mapping

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:34
> +
> +int main(int argc, char** argv) {
> +    QCoreApplication app(argc,argv);

new line before {

> translatedcountrylist.cpp:32
> +
> +#include <QDebug>
> +

not necessary I think

> translatedcountrylist.cpp:61
> +
> +TranslatedCountries::TranslationCountryMap TranslatedCountries::parseFilePath(const QString& filePath)
> +{

coding style space before "&" or "*" everywhere in file.

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D14563

To: vkrause, mlaurent
Cc: mlaurent, svuorela, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180803/60ace989/attachment.html>