D14960: Akonadi protocol: an invalid response is still a response.

[David Faure]

dfaure created this revision.
dfaure added reviewers: dvratil, vkrause.
Herald added a project: KDE PIM.
Herald edited subscribers, added: kde-pim; removed: KDE PIM.
dfaure requested review of this revision.

REVISION SUMMARY
  The _ResponseBit wasn't set, which made some of protocoltest fail
  (ever since it was initially written in 5636aaf <https://phabricator.kde.org/R165:5636aaf3931069d723e9f723dbfe7168654aed61> so this isn't a regression!),
  and which would even lead to a crash (detected by that test) when doing
  res->isError() after serializeAndDeserialize which didn't actually create a
  Response subclass...

TEST PLAN
  protocoltest went from 3 failures to 1, the last one being the protocol version
  (but given the comment next to it, I emailed Dan...)

REPOSITORY
  R165 Akonadi

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D14960

AFFECTED FILES
  src/private/protocol.cpp
  src/private/protocol_p.h

To: dfaure, dvratil, vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180820/22c7ab0d/attachment.html>