D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list

[Martin Koller]

On Montag, 6. August 2018 21:30:06 CEST Daniel Vrátil wrote:
> dvratil added a comment.
> 
> 
>   @winterz, @mkoller can you check that the application crash is preceded by `FetchHelper requested from within a transaction, aborting, since this would deadlock!` message from the Akonadi Server in terminal?

This is what I get (without my patch) when hitting "check for mails" in kmail:

20180807 15:13:21.422 CEST akonadiserver: New notification connection (registered as Akonadi::Server::NotificationSubscriber(0x7fc86c256620) )
20180807 15:13:21.425 CEST akonadi_airsyncdownload_resource_1: "2018-08-07T15:13:21" sent ...
20180807 15:13:21.450 CEST akonadiserver: Subscriber Akonadi::Server::NotificationSubscriber(0x7fc86c256620) identified as "SpecialCollectionsMonitor - 34097472"
20180807 15:13:21.462 CEST akonadiserver: only display
20180807 15:13:23.503 CEST akonadi_maildispatcher_agent: ASSERT: "!isEmpty()" in file /usr/include/qt5/QtCore/qvector.h, line 237
KCrash: Application 'akonadi_maildispatcher_agent' crashing...
KCrash: Attempting to start /usr/lib64/libexec/drkonqi from kdeinit
sock_file=/run/user/1000/kdeinit5__0
20180807 15:13:23.510 CEST akonadi_pop3_resource_3: ASSERT: "!isEmpty()" in file /usr/include/qt5/QtCore/qvector.h, line 237
KCrash: Application 'akonadi_pop3_resource' crashing...
KCrash: Attempting to start /usr/lib64/libexec/drkonqi from kdeinit
sock_file=/run/user/1000/kdeinit5__0
20180807 15:13:23.533 CEST akonadiserver: Subscriber "MessageListTagCacheMonitor - 159607920" disconnected
20180807 15:13:23.533 CEST akonadiserver: Shutting down "kmail2-182605794-SearchSession" ...
20180807 15:13:23.534 CEST akonadiserver: Subscriber "FilterManagerTagMonitor - 89852432" disconnected
20180807 15:13:23.534 CEST akonadiserver: Subscriber "TagActionManagerMonitor - 41244992" disconnected
20180807 15:13:23.534 CEST akonadiserver: Subscriber "MessageViewerMonitor - 41657344" disconnected
20180807 15:13:23.534 CEST akonadiserver: Subscriber "MessageListTagMonitor - 41457536" disconnected
20180807 15:13:23.534 CEST akonadiserver: Shutting down "MessageViewer-41656784" ...
20180807 15:13:23.534 CEST akonadiserver: Subscriber "SpecialCollectionsMonitor - 40987248" disconnected
20180807 15:13:23.535 CEST akonadiserver: Subscriber "KMail Kernel ETM - 38469360" disconnected
20180807 15:13:23.536 CEST akonadiserver: Shutting down "KMail Kernel ETM" ...
20180807 15:13:23.537 CEST akonadiserver: Shutting down "kmail2-182605794" ...
20180807 15:13:23.544 CEST akonadiserver: New notification connection (registered as Akonadi::Server::NotificationSubscriber(0x7fc86c23bd10) )
20180807 15:13:23.545 CEST akonadiserver: Subscriber Akonadi::Server::NotificationSubscriber(0x7fc86c23bd10) identified as "SpecialCollectionsMonitor - 27662752"

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\                        - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at