D14629: Process IMAP Quota roots with associated quotas only

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Thanks for adding the test! Just one nitpick and we are good to go :)

INLINE COMMENTS

> testretrievecollectionmetadatatask.cpp:349-372
> +        expectedRoots.clear();
> +        expectedRoots.append("mailbox1");
> +        expectedRoots.append("INBOX");
> +        expectedRoots.append("mailbox3");
> +        expectedUsages.clear();
> +        key.clear();
> +        key.insert("STORAGE", 21);

May I suggest using C++11 initializer lists here, instead of this whole block?

  expectedRoots = { "mailbox1", "INBOX", "mailbox3" };
  expectedUsages = { {{"STORAGE", 21}}, {{"STORAGE", 11"}}, {{"STORAGE", 31}} };
  expectedLimits = { {{"STORAGE", 512}}, {{"STORAGE", 250}}, {{"STORAGE", 500}} };

I find it much easier to read (not that it matters too much in the test code, just nitpicking here).

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D14629

To: gkowal, #kde_pim, mlaurent, dvratil
Cc: mlaurent, dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180810/03fab6d1/attachment.html>