D15179: Fixup setting password

Luca Beltrame noreply at phabricator.kde.org
Fri Aug 31 08:09:11 BST 2018


lbeltrame created this revision.
lbeltrame added a reviewer: mlaurent.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.
lbeltrame requested review of this revision.

REVISION SUMMARY
  6c0464d203066cddadc9383867d6d585b0e613f4 <https://phabricator.kde.org/R84:6c0464d203066cddadc9383867d6d585b0e613f4> fixed sending mails when inputting
  the password directly. However, due to a (likely) copy paste error,
  setPassword now takes transport->password() directly isntead of using the
  passwd variable defined a few lines above.
  
  This way passwd will be never read.

TEST PLAN
  No test, just looked at the logic of the above commit

REPOSITORY
  R84 PIM: KMail Transport

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D15179

AFFECTED FILES
  src/kmailtransport/plugins/smtp/smtpjob.cpp

To: lbeltrame, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180831/2512a6f9/attachment.html>


More information about the kde-pim mailing list