D12612: Akonadi: CollectionRequester::Private::fetchCollection crash guard

Daniel Vrátil noreply at phabricator.kde.org
Mon Apr 30 16:12:21 BST 2018


dvratil added a comment.


  I generally don't see a problem with guarding against a null pointer or a bad cast, but in this case the bad pointer would just get forwarded to `_collectionsNamesReceived()` in the `else` branch, so you need to add protection there as well.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D12612

To: winterz, mlaurent
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180430/58aa8bb4/attachment.html>


More information about the kde-pim mailing list