D11830: Switch the pkpass formatter plugin to use KPkPass

Volker Krause noreply at phabricator.kde.org
Sun Apr 1 09:57:39 BST 2018


vkrause added inline comments.

INLINE COMMENTS

> knauss wrote in CMakeLists.txt:124
> A okay- well I parsed the KP as shorthand for kde pim. What about KPimPkPass?

And KPim::PkPass in CMake, yes. Also makes a possible future migration to KF5 easier, "KPim" is easier to search/replace than "K".

> knauss wrote in pkpass_plugin.cpp:105
> can't you can return a default value, if no property is given. In messagelib/messageviewer/src/messagepartthemes/default/messagepartrenderermanager.cpp i needed to write my own lookup functions, maybe the macros are not working for this anymore.

I don't think this works, as Grantlee seems to use the lookup functions only when encountering a "." followed by a string, for a type with a custom lookup function registered.

A custom string conversion function is possible in theory via QMetaType::registerConverter, but that does not accept a conversion  between two built-in types, so that also does not help in the case of QColor.

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D11830

To: vkrause, #kde_pim
Cc: knauss, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180401/e684699e/attachment.html>


More information about the kde-pim mailing list