D12480: Several performance optimisations for Akregator

Laurent Montel noreply at phabricator.kde.org
Tue Apr 24 12:56:32 BST 2018


mlaurent added inline comments.

INLINE COMMENTS

> article.h:75
> +
> +    Article(const QString &guid, Feed *feed, Backend::FeedStorage *archive);
> +

Perhaps you can merge this two constructors no ?

> feedstoragemk4impl.h:47
>  
> +    void article(const QString & guid, uint & hash, QString & title, int & status, QDateTime & pubDate) const override;
>      bool contains(const QString &guid) const override;

coding style. Remove space after &

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D12480

To: pinaraf, mlaurent, knauss
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180424/0f3b8cfa/attachment.html>


More information about the kde-pim mailing list