D11830: Switch the pkpass formatter plugin to use KPkPass

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:21
> you can remove this line too as we don't call update this macro
> find_package(SharedMimeInfo ${SharedMimeInfo_MINIMUM_VERSION} REQUIRED)

Indeed, I'll fix that.

> knauss wrote in pkpass_plugin.cpp:27
> either <PkPass or <KPimPkPass to be consitent

This now follows the KF5 naming patterns, ie. namespacing the library with "KF5" (or "KPim" here), and namespacing the C++ namespace with "K". I used the pattern you suggest initially in KF5::SyntaxHighlighting, and had to change it to the KSyntaxHighlighting namespace in review. So for consistency I'd follow KF5 here.

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D11830

To: vkrause, #kde_pim, mlaurent
Cc: mlaurent, knauss, dvasin, winterz, vkrause, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180403/f683c9b0/attachment.html>