D12454: Article viewer: Zoom has to be applied after page starts to load

Thomas Brix Larsen noreply at phabricator.kde.org
Sun Apr 22 18:43:58 BST 2018


thomasbrixlarsen created this revision.
thomasbrixlarsen added a project: KDE PIM.
Restricted Application added a subscriber: KDE PIM.
thomasbrixlarsen requested review of this revision.

REVISION SUMMARY
  Arch Linux package updates articles are currently being rendered without zoom.
  
  I have tested moving the call to setZoomFactor to later QWebEnginePage signals to find the optimal place to put it.
  
  loadFinished: Renders zoomed, but only after the article is fully loaded.
  loadStarted: Renders without zoom.
  loadProgress: Renders zoomed, but is called multiple times. In my tests the worst observed number of calls was 8 (on a Phoronix article) adding ~1 ms to article load time.
  
  This patch implements the loadProgress option.

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D12454

AFFECTED FILES
  src/articleviewer-ng/webengine/articleviewerwebenginepage.cpp
  src/articleviewer-ng/webengine/articleviewerwebenginepage.h

To: thomasbrixlarsen
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180422/911b37b2/attachment.html>


More information about the kde-pim mailing list