D12461: Akonadiconsole: support incidences serialized in the binary format

David Faure noreply at phabricator.kde.org
Sun Apr 22 23:10:26 BST 2018


dfaure created this revision.
dfaure added a reviewer: dvratil.
Restricted Application added a project: KDE PIM.
dfaure requested review of this revision.

REVISION SUMMARY
  This experiment shows, however, that the "raw payload" really isn't the
  actual raw payload from the DB, but rather the deserialized payload,
  serialized again, i.e. it's "raw" only if the serializer is
  actually symmetrical...
  
  For this reason I'm wondering if the "converted from binary" comment is
  a good idea after all, it makes it sound like the raw payload in the DB
  is in the binary format, even when it's not.

TEST PLAN
  clicking on events in akonadiconsole, with KCALCORE_BINARY_SERIALIZER=1,
  shows "converted from binary" for all events. Without this patch, it showed binary
  garbage for all events.

REPOSITORY
  R199 Akonadi Console

BRANCH
  Applications/18.04

REVISION DETAIL
  https://phabricator.kde.org/D12461

AFFECTED FILES
  src/browserwidget.cpp

To: dfaure, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180422/4367c6dc/attachment.html>


More information about the kde-pim mailing list