D12574: Support deleting ThemeManager after actiongroup and menu, to fix crash in kmail
David Faure
noreply at phabricator.kde.org
Sat Apr 28 10:56:05 BST 2018
dfaure created this revision.
dfaure added a reviewer: mlaurent.
Restricted Application added a project: KDE PIM.
dfaure requested review of this revision.
REVISION SUMMARY
We used to leak the ThemeManager. Now that we delete it, it crashed
because we delete the action group and the menu first. Add support for
setActionGroup(nullptr) and setThemeMenu(nullptr) so we can clean up while
everything still exists.
TEST PLAN
Unittest. The actual fix for kmail requires calling these methods
in grantleeheaderstyleplugin.
REPOSITORY
R77 PIM: Grantlee Theme
BRANCH
Applications/18.04
REVISION DETAIL
https://phabricator.kde.org/D12574
AFFECTED FILES
autotest/grantleethememanagertest.cpp
src/grantleethememanager.cpp
To: dfaure, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180428/c79f3f1b/attachment.html>
More information about the kde-pim
mailing list