D12474: Always add domain delimiter if "Domain" checkbox is selected

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: dvratil.
Restricted Application added a project: KDE PIM.
bruns requested review of this revision.

REVISION SUMMARY
  EwsConfigDialog::fullUsername() always adds the domain delimiter when
  the "Domain" checkbox is set, even if the actual domain name is empty,
  while the login procedure in EwsResource::passwordRequestFinished(...)
  only adds a domain delimiter if the domain is non-empty. Make sure
  login in the config dialog and during normal operation is equivalent.
  
  Not sending an (empty) domain causes login failures for some servers,
  while sending it seems to be unproblematic, and can be forced off by
  unselecting the checkbox.
  
  This fixes a regression caused by commit
  7c74258355cd <https://phabricator.kde.org/R44:7c74258355cd91106d7563142177dd7f17801256> ("EWS: Refactor server connection and password retrieval"),
  which changed the check for sending the domain from mSettings->hasDomain()
  to mSettings->domain().isEmpty().
  
  BUG: 388496
  CCBUG: 390798

TEST PLAN
  Create a new folder (either using web client or kontact)
  Make sure it appears in kontact
  Delete it in the web client (or using kontact on another computer)

REPOSITORY
  R44 KDE PIM Runtime

BRANCH
  delimiter_with_empty_domain

REVISION DETAIL
  https://phabricator.kde.org/D12474

AFFECTED FILES
  resources/ews/ewsresource.cpp

To: bruns, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180423/5269bda2/attachment.html>