D7928: Do not mark messages as unread immediately, makes unread/new filter unusable

Jonathan Marten noreply at phabricator.kde.org
Fri Sep 29 11:42:29 BST 2017


marten updated this revision to Diff 20084.
marten added a comment.


  I've done some more investigating and the simplified 2-parameter version doesn't seem to work correctly, in the case where the "Important" article flag is toggled  by Article::setKeep().  If the article is already read then the flag is correctly changed but, because of the newStatus!=Read check, the article list is not visually updated - until the Akregator main window loses focus(!).
  
  The only way to distinguish the mark-as-read case from any other is to have the 3rd bool parameter.  So the diff is reverted to the original version as per the patch.

REPOSITORY
  R201 Akregator

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7928?vs=20037&id=20084

REVISION DETAIL
  https://phabricator.kde.org/D7928

AFFECTED FILES
  src/article.cpp
  src/feed/feed.cpp
  src/feed/feed.h

To: marten, #kde_pim
Cc: anthonyfieroni, cfeck, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170929/a779ee98/attachment.html>


More information about the kde-pim mailing list