D7858: Only remove init connections to the database on server shutdown.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Thanks a lot, patch looks good, just some minor coding adjustments needed.
  
  You can change "CCBUG" to "BUG" in the commit message so that the bug gets auto-closed once this is committed since the patch actually fixes the issue.

INLINE COMMENTS

> akonadi.cpp:431
> +        const QLatin1String initCon("initConnection");
> +        QSqlDatabase::removeDatabase(initCon);
>          return;

`QSqlDatabase::removeDatabase(QStringLiteral("initConnection'));`

> dbconfigmysql.cpp:522
> +    const QLatin1String initCon("initConnection");
> +    QSqlDatabase::removeDatabase(initCon);
> +

`QSqlDatabase::removeDatabase(QStringLiteral("initConnection"));`

Also please add a comment that we are closing initConnection this late to workaround a QTBUG-63108.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D7858

To: pprkut, dvratil, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170917/7f615a17/attachment.html>