D8068: Merge Interface::MessagePart and MessagePart
Sandro Knauß
noreply at phabricator.kde.org
Sat Sep 30 13:10:02 BST 2017
knauss added inline comments.
INLINE COMMENTS
> messagepartrenderer.cpp:38
> {
> auto mp = msgPart.dynamicCast<MimeTreeParser::MessagePart>();
> if (mp) {
useless now, because it is always a MimeTreeParser::MessagePart:)
> messagepart.h:77
> MessagePart(ObjectTreeParser *otp, const QString &text);
> + ~MessagePart();
>
doesn't it need to be virtual?
> messagepart.h:150
> friend class AlternativeMessagePart;
> - friend class ::PartPrivate;
> };
please keep them, these are for the new planned interface
REPOSITORY
R94 PIM: Message Library
REVISION DETAIL
https://phabricator.kde.org/D8068
To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170930/31e0a4fb/attachment.html>
More information about the kde-pim
mailing list