D7862: Enhancement: Resource tomboynotes updates its content automatically

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  I assume the license changes should not be there? That would make the license inconsistent with the rest of the resource code.

INLINE COMMENTS

> configdialog.ui:89
> +       <item>
> +        <widget class="KLineEdit" name="kcfg_refreshInterval"/>
> +       </item>

Use QSpinBox rather than KLineEdit, you can do it like

[QLabel "Update interval:"] [QSpinBox] [QLabel "minutes"]

> tomboycollectionsdownloadjob.h:6
>      under the terms of the GNU Library General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or (at your
> +    the Free Software Foundation; either version 3 of the License, or (at your
>      option) any later version.

Unrelated change?

> tomboynotesresource.cpp:81
> +    int refreshInterval = Settings::self()->refreshInterval();
> +        if (refreshInterval == 0) {
> +            refreshInterval = -1;

Wrong indentation

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D7862

To: Stefan, dvratil, #kde_pim
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170917/005102b4/attachment.html>