D8189: Port the WKS formatter to the new rendering API

Sandro Knauß noreply at phabricator.kde.org
Mon Oct 9 10:38:34 BST 2017


knauss added inline comments.

INLINE COMMENTS

> wks-confirmation-request-multipart-decrypted.mbox.html:28
> +        <div style="padding: 5pt">
> +          <div style="font-size: large; text-align: center; padding-bottom: 20pt;">Register your OpenPGP key with your email provider.</div>
> +          <p>When you register your key with your email provider other people will then be able to retrieve the key and send you encrypted emails and verify authenticity of emails you send them.</p>

right-to-left support?

> gnupgwksformatter.cpp:75
> +            QByteArray plainText;
> +            auto result = decrypt->exec(part.content()->decodedContent(), plainText);
> +            if (result.error()) {

should be start and handled via memento to not block kmail. but this is another issue.

> plugin.cpp:30
>      application_pgp_keys,
> -    multipart_mixed,
> -    application_vnd_gnupg_keys
> +    application_vnd_gnupg_keys,
> +    multipart_mixed

why resort the Index?

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D8189

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171009/ef14f783/attachment.html>


More information about the kde-pim mailing list