D8162: Attachment open confirmation dialogue: Show icons on buttons

[Jonathan Marten]

marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  This change shows theme icons on the "Open With..." button (the standard "document-open" icon) and on the "Open with 'application'" button (the application's icon as defined in its service file).  These buttons previously had no icons, but the other two in the dialogue did so unbalancing the appearance.
  
  The dialogue text is converted to KUIT markup.
  
  This requires passing the service 'offer' to AttachmentDialog::AttachmentDialog(), instead of the application name.

TEST PLAN
  Built messagelib with this change, checked for correct operation and appearance of the dialogue in KMail.
  
  F4987121: kmail5-attachmentopen-Dx.png <https://phabricator.kde.org/F4987121>

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D8162

AFFECTED FILES
  messageviewer/src/viewer/viewer_p.cpp
  messageviewer/src/widgets/attachmentdialog.cpp
  messageviewer/src/widgets/attachmentdialog.h

To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171006/4d7c7457/attachment.html>