D8102: Port internal render plugins to HtmlWriter

Volker Krause noreply at phabricator.kde.org
Mon Oct 2 15:30:33 BST 2017


vkrause added inline comments.

INLINE COMMENTS

> knauss wrote in defaultrenderer.cpp:868
> we need a loop here to get all plugins. the registry.at(0) was just a shortcut to test my idea ( but its outofscope here). But here the streaming api has a big disadvantage, because you need to trust, that the plugin don't write anything to htmlWriter if it don't handle the MessagePart otherwise things get messed up in htmlWriter. Or can you somehow seek the output again, when a plugin don't handle the part aka return false?

The loop is coming in the patch adding proper plugin handling (still WIP).

Rewinding the stream to a defined restore point is possible if we need that, similar to what QIODevice::start/commit/rollbackTransaction do for the read direction.

> knauss wrote in textmessagepartrenderer.cpp:44
> can be deleted.

done in the DRP removal patch

> knauss wrote in textmessagepartrenderer.cpp:75
> we have drp that has already the method drp->alignText()

Addressed in the subsequent patch removing drp.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D8102

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171002/ebb8f287/attachment.html>


More information about the kde-pim mailing list