D8189: Port the WKS formatter to the new rendering API

Volker Krause noreply at phabricator.kde.org
Tue Oct 10 19:53:56 BST 2017


vkrause added inline comments.

INLINE COMMENTS

> knauss wrote in wks-confirmation-request-multipart-decrypted.mbox.html:28
> i know, but still it needs to be fixed :)

sure, but let's address this separately then, not as part of an unrelated patch

> knauss wrote in gnupgwksformatter.cpp:75
> i know, but still it needs to be fixed :)

dito

> knauss wrote in plugin.cpp:30
> i don't get this. can you point me to the part where I see that?

that's in the json file, the renderer section only has two entries, so those need to be on 0 and 1 in this enum

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D8189

To: vkrause, knauss
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171010/eb31b22c/attachment.html>


More information about the kde-pim mailing list