D7775: Initial submission of Akonadi EWS Resource to KDE PIM

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> ewsfetchcalendardetailjob.cpp:122
> +        if (incidence) {
> +            QString msTz = ewsItem[EwsItemFieldTimeZone].toString();
> +            QString culture = ewsItem[EwsItemFieldCulture].toString();

This looks unused now?

Does the EWSItem contain actual information regarding the timezone, except for its name, like UTC offset and DST transitions?

I know realize KCalCore may not have the API you might need to get this working properly, but I don't know how much information you actually have available for EWS events

> ewsfetchcalendardetailjob.cpp:177
> +        setError(1);
> +        setErrorText(QStringLiteral("Job is not an instance of EwsGetItemRequest"));
> +        emitResult();

If the errorText of the job is passed to Akonadi::ResourceBase::cancelTask() at some point, it should be localized (and probably less technical, that's what debug output is for)

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D7775

To: nowicki, #kde_pim, dvratil, mlaurent
Cc: kde-pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171001/33897e51/attachment.html>