D8537: Add templates for Akonadi resource and serializer plugins

Laurent Montel noreply at phabricator.kde.org
Sat Oct 28 15:27:55 BST 2017


mlaurent added inline comments.

INLINE COMMENTS

> CMakeLists.txt:5
> +
> +set(ECM_MIN_VERSION "5.13.0")
> +find_package(ECM ${ECM_MIN_VERSION} CONFIG REQUIRED)

5.13.0 ? it seems very old

> CMakeLists.txt:16
> +
> +set(QT_MIN_VERSION "5.3.0")
> +find_package(Qt5 ${QT_MIN_VERSION} REQUIRED Core DBus Gui)

5.3.0? all kdepim depend against 5.8.0 => 5.3.0...

> CMakeLists.txt:5
> +
> +set(ECM_MIN_VERSION "5.13.0")
> +find_package(ECM ${ECM_MIN_VERSION} CONFIG REQUIRED)

5.13.0? qt 5.3.0 ?

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D8537

To: kossebau, mlaurent, dvratil
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171028/12db46f2/attachment.html>


More information about the kde-pim mailing list